-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hemdi] Storybook 7 Migration #71
Open
hemudi
wants to merge
4
commits into
dev
Choose a base branch
from
env/storybook-migration/#64
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
643d7bd
:arrow_up: update to the latest version of storybook
hemudi cabf9a0
:recycle: convert @cos-ui/primitives stories CSF2 to CSF3
hemudi f15c02c
:recycle: convert @cos-ui/react stories CSF2 to CSF3
hemudi bc24921
:heavy_plus_sign: add storybook vite builder
hemudi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
packages/primitives/src/components/Dropdown/dropdown.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 3 additions & 7 deletions
10
packages/primitives/src/components/TextArea/textArea.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
import { ComponentStory, ComponentMeta } from '@storybook/react'; | ||
import { Meta } from '@storybook/react'; | ||
|
||
import { TextArea } from '.'; | ||
|
||
export default { | ||
title: 'Primitives/TextArea', | ||
component: TextArea, | ||
} as ComponentMeta<typeof TextArea>; | ||
} as Meta<typeof TextArea>; | ||
|
||
const Template: ComponentStory<typeof TextArea> = (args) => ( | ||
<TextArea {...args} /> | ||
); | ||
|
||
export const Default = Template.bind({}); | ||
export const Default = {}; |
10 changes: 3 additions & 7 deletions
10
packages/primitives/src/components/TextInput/textInput.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
import { ComponentStory, ComponentMeta } from '@storybook/react'; | ||
import { Meta } from '@storybook/react'; | ||
|
||
import { TextInput } from '.'; | ||
|
||
export default { | ||
title: 'Primitives/TextInput', | ||
component: TextInput, | ||
} as ComponentMeta<typeof TextInput>; | ||
} as Meta<typeof TextInput>; | ||
|
||
const Template: ComponentStory<typeof TextInput> = (args) => ( | ||
<TextInput {...args} /> | ||
); | ||
|
||
export const Default = Template.bind({}); | ||
export const Default = {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 코드 기반으로 Storybook 실행을 시켜보니, Avatar, Icon 등이 제대로 동작하지 않았어요, 이유는 css prop 을 변환시켜 주지 않은 거라서, 아래처럼 vite config 를 추가해주면 좋을 것 같습니다.
Storybook 에서는 vite.config.ts 에서 설정을 가져오게하는 법을 얘기하는데, 모노레포이기도 하고, 각 패키지가 동일한 vite config 를 활용할 것같진 않아서 루트에서 공유되어 사용되기보다 각각 관리하는게 맞다고 생각합니다.