Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination component #39

Merged
merged 13 commits into from
Dec 16, 2024
Merged

Pagination component #39

merged 13 commits into from
Dec 16, 2024

Conversation

F-sh2019
Copy link
Collaborator

Description

1) What does this PR do? 2) List out what you did.

Implemented Pagination Component and Used it in Alldrug page

_Provide a link to the related issue

Type of Changes

Feature update/change/addition, bug fix, styling update, etc.

Acceptance Criteria

Include the checked-off acceptance criteria from the issue.

Update Screenshots

Provide screenshots of the view before and after the changes.

Before

After

image

Testing Instructions

In a list format, tell us how to test this PR.
-Totalitem in a page is a parameter in this component sending by parent : here is 10 and it is defined in ALLDrug page
-The pagination should work properly after filtering data in the page

Learnings (Optional)

Document any things you learned or 'gotchas' you experienced.

Copy link
Collaborator

@GinaCastromonte GinaCastromonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't sign in for this PR due to a manual token present in one of the files. Once that's removed, everything worked perfectly.

@F-sh2019
Copy link
Collaborator Author

I couldn't sign in for this PR due to a manual token present in one of the files. Once that's removed, everything worked perfectly.

I corrected it. Its know reading the token available the local storage.Thank you for reviewing

@ValeriGuerrero ValeriGuerrero merged commit 8ca6f2b into main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants