Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout functionality #62

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Logout functionality #62

merged 5 commits into from
Jan 2, 2025

Conversation

sarross88
Copy link
Collaborator

Description

_1) Menu is dynamic and based on the user's role, the logout functionality is now working

Copy link
Collaborator

@F-sh2019 F-sh2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating code.There are somethings to consider:
1- the Register page does not load empty,It has the info of the previous user!
2- After registering a new user by admin, it need to redirect to user management otherwise to the login page.

@devandres-tech
Copy link
Collaborator

@sarross88 @F-sh2019 @GinaCastromonte hey guys, is the following the expected functionality?

  1. I log in as User A (admin)
  2. I create a new User B via register page while still logged in with User A
  3. After filling out the register form to register User B, it logs User A out. It redirects to login page

Shouldn't we keep User A logged in and redirect them to user management page? I think this is what @F-sh2019 was seeing as well.

@ValeriGuerrero ValeriGuerrero merged commit 60bf0ef into main Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants