Rb 64 controllers routes for order #28
Open
+286
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrudnitskaya
reviewed
Jan 8, 2025
vrudnitskaya
reviewed
Jan 8, 2025
vrudnitskaya
reviewed
Jan 8, 2025
src/controllers/orderController.js
Outdated
| } | ||
| }; | ||
|
|
||
| const cancelOrder = async (req, res, next) => { |
There was a problem hiding this comment.
I think we also need to specify who is allowed to cancel the order and check their ID to confirm whether they are the user or the buyer of this order.
|
Great job, Tanya! Please pay attention to my comments. |
benochi
reviewed
Jan 8, 2025
benochi
reviewed
Jan 8, 2025
| const orderAmount = calculateCartTotal(tempCart, buyerLocation, sellerLocation); | ||
|
|
||
| const order = await Order.create({ | ||
| orderNumber: `ORD-${Date.now()}-${sellerId.slice(-5)}`, |
There was a problem hiding this comment.
can you test that invalid data can't throw an error here, like a missing createdBy(if we are validating that, then it should never be missing so its pretty solid, but always good to check.
benochi
reviewed
Jan 8, 2025
benochi
reviewed
Jan 8, 2025
| const sellerLocation = items[0].book.createdBy.location; | ||
| const orderAmount = calculateCartTotal(tempCart, buyerLocation, sellerLocation); | ||
|
|
||
| const order = await Order.create({ |
There was a problem hiding this comment.
Just a NOTE: You would want to use UUID to avoid collisions in real world scenarios:
ORD-${Date.now()}-${sellerId.slice(-5)}
benochi
reviewed
Jan 8, 2025
benochi
reviewed
Jan 8, 2025
src/controllers/orderController.js
Outdated
| try { | ||
| const { id: orderId } = req.params; | ||
| const order = await Order.findByIdAndUpdate(orderId, { status: 'Cancelled' }, { new: true, runValidators: true }); | ||
|
|
There was a problem hiding this comment.
Is all order related data correctly cleaned up on cancel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add controller for order and routes
Changes
Related issues
Screenshots