Skip to content

Commit

Permalink
Code review.
Browse files Browse the repository at this point in the history
  • Loading branch information
CodeBlanch committed Aug 22, 2024
1 parent 9aaa695 commit f982bdb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions docs/attributes-registry/service.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ port.

**[3]:** A string value having a meaning that helps to distinguish a group of services, for example the team name that owns a group of services. `service.name` is expected to be unique within the same namespace. If `service.namespace` is not specified in the Resource then `service.name` is expected to be unique for all services that have no explicit namespace defined (so the empty/unspecified namespace is simply one more valid namespace). Zero-length namespace string is assumed equal to unspecified namespace.

**[4]:** When possible, service detector component MAY use
language/platform-specific capabilities to determine application
version and populate `service.version` automatically.
**[4]:** When possible, SDKs MAY use language/platform-specific capabilities to
determine application version and populate `service.version`
automatically.

If `service.version` is provided explicitly it MUST take priority over
the version determined automatically.
6 changes: 3 additions & 3 deletions docs/resource/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ as specified in the [Resource SDK specification](https://github.com/open-telemet

**[1]:** MUST be the same for all instances of horizontally scaled services. If the value was not specified, SDKs MUST fallback to `unknown_service:` concatenated with [`process.executable.name`](process.md), e.g. `unknown_service:bash`. If `process.executable.name` is not available, the value MUST be set to `unknown_service`.

**[2]:** When possible, service detector component MAY use
language/platform-specific capabilities to determine application
version and populate `service.version` automatically.
**[2]:** When possible, SDKs MAY use language/platform-specific capabilities to
determine application version and populate `service.version`
automatically.

If `service.version` is provided explicitly it MUST take priority over
the version determined automatically.
Expand Down
6 changes: 3 additions & 3 deletions model/registry/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ groups:
brief: >
The version string of the service API or implementation. The format is not defined by these conventions.
note: |
When possible, service detector component MAY use
language/platform-specific capabilities to determine application
version and populate `service.version` automatically.
When possible, SDKs MAY use language/platform-specific capabilities to
determine application version and populate `service.version`
automatically.
If `service.version` is provided explicitly it MUST take priority over
the version determined automatically.
Expand Down

0 comments on commit f982bdb

Please sign in to comment.