fixing tests

CodeCavePro · Oct 18, 2023 · 8b52bfd · 8b52bfd
1 parent 42d7236
commit 8b52bfd
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 15 deletions.
diff --git a/src/Thumbnails/RevitTumbnailExtractor.cs b/src/Thumbnails/RevitTumbnailExtractor.cs
@@ -84,13 +84,11 @@ private static int GetPngOffset(byte[] thumbnailBytes)
                         {
                             return startingOffset;
                         }
-
                         if (markerFound && (previousValue == RevitFileMap.PngImageMarker.MARKER_13))
                         {
                             previousValue = pointer;
                             continue;
                         }
-
                         markerFound = false;
                         break;
 
@@ -100,7 +98,6 @@ private static int GetPngOffset(byte[] thumbnailBytes)
                             previousValue = pointer;
                             continue;
                         }
-
                         markerFound = false;
                         break;
 
@@ -110,7 +107,6 @@ private static int GetPngOffset(byte[] thumbnailBytes)
                             previousValue = pointer;
                             continue;
                         }
-
                         markerFound = false;
                         break;
 
@@ -120,7 +116,6 @@ private static int GetPngOffset(byte[] thumbnailBytes)
                             previousValue = pointer;
                             continue;
                         }
-
                         markerFound = false;
                         break;
 
@@ -130,7 +125,6 @@ private static int GetPngOffset(byte[] thumbnailBytes)
                             previousValue = pointer;
                             continue;
                         }
-
                         markerFound = false;
                         break;
 
@@ -140,7 +134,6 @@ private static int GetPngOffset(byte[] thumbnailBytes)
                             previousValue = pointer;
                             continue;
                         }
-
                         markerFound = false;
                         break;
                 }

diff --git a/tests/Resources/Thumbnails/Valid/7-PS-66_R3.png b/tests/Resources/Thumbnails/Valid/7-PS-66_R3.png
diff --git a/tests/Resources/Thumbnails/Valid/A1ANG-3.png b/tests/Resources/Thumbnails/Valid/A1ANG-3.png
diff --git a/tests/Resources/Thumbnails/Valid/U0000850_7-PS-66.png b/tests/Resources/Thumbnails/Valid/U0000850_7-PS-66.png
diff --git a/tests/Resources/Thumbnails/Valid/qf_hatco_hdw-2bn_cat.png b/tests/Resources/Thumbnails/Valid/qf_hatco_hdw-2bn_cat.png
diff --git a/tests/ThumbnailFixture.cs b/tests/ThumbnailFixture.cs
@@ -33,15 +33,16 @@ public void DwgThumbnailIsGenerated(string dwgRelativePath)
             // Setup
             dwgRelativePath = dwgRelativePath?.Replace('/', Path.DirectorySeparatorChar);
             var dwgFilePath = Directory.GetFiles(PathToValidFiles, "*.dwg").FirstOrDefault(f => f.EndsWith(dwgRelativePath));
-            var dwgThumbnailPath = Path.ChangeExtension(Path.Combine(Environment.CurrentDirectory, Path.GetFileName(dwgFilePath)), "png");
+            var dwgThumbnailPath = Path.ChangeExtension(dwgFilePath, "png");
 
             // Act
             var dwgThumbnailer = new DwgThumbnailExtractor();
-            var fileExtracted = dwgThumbnailer.TryExtractFile(dwgFilePath, dwgThumbnailPath);
+            var thumbDwgBytes = dwgThumbnailer.ExtractThumbnailBytes(dwgFilePath);
+            var thumbPngBytes = File.ReadAllBytes(dwgThumbnailPath);
 
             // Assert
-            Assert.True(fileExtracted);
-            Assert.True(File.Exists(dwgThumbnailPath));
+            Assert.NotEmpty(thumbDwgBytes);
+            Assert.Equal(thumbPngBytes, thumbDwgBytes);
         }
 
         /// <summary>The thumbnails are generated for RFAs.</summary>
@@ -53,15 +54,16 @@ public void RfaThumbnailIsGenerated(string rfaRelativePath)
             // Setup
             rfaRelativePath = rfaRelativePath?.Replace('/', Path.DirectorySeparatorChar);
             var rfaFilePath = Directory.GetFiles(PathToValidFiles, "*.rfa").FirstOrDefault(f => f.EndsWith(rfaRelativePath));
-            var rfaThumbnailPath = Path.ChangeExtension(Path.Combine(Environment.CurrentDirectory, Path.GetFileName(rfaFilePath)), "png");
+            var rfaThumbnailPath = Path.ChangeExtension(rfaFilePath, "png");
 
             // Act
             var rfaThumbnailer = new RevitTumbnailExtractor();
-            var fileExtracted = rfaThumbnailer.TryExtractFile(rfaFilePath, rfaThumbnailPath);
+            var thumbRfaBytes = rfaThumbnailer.ExtractThumbnailBytes(rfaFilePath);
+            var thumbPngBytes = File.ReadAllBytes(rfaThumbnailPath);
 
             // Assert
-            Assert.True(fileExtracted);
-            Assert.True(File.Exists(rfaThumbnailPath));
+            Assert.NotEmpty(thumbRfaBytes);
+            Assert.Equal(thumbPngBytes, thumbRfaBytes);
         }
     }
 }