Implemented Global Notification System #1984
Open
+1,071
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a global notification system in CodeEdit that allows users to receive and manage notifications across all open workspaces. Notifications provide important alerts and updates while ensuring consistency across multiple instances of the application.
Key Features
Temporary Notifications:
Sticky Notifications:
Notification Button & Popover:
Behavior:
Screenshots
Screen.Recording.2025-02-14.at.4.09.29.PM.mp4
Screen.Recording.2025-02-14.at.5.36.32.PM.mov
The following screen recording showcases the first iteration. In the design channel on Discord, @thecoolwinter suggested moving in this direction. While it required a bit more effort, I agree that it ultimately results in a much cleaner and more polished look.
Screen.Recording.2025-02-12.at.12.42.55.PM.mov
Usage
With a symbol (works with both SF Symbols and CodeEditSymbols)
The icon defaults to the users accent color if one isn't specified however you can specify a color here...
With a custom image...
With an emoji...
With text...
Future Considerations
Currently, NotificationManager is shared between workspaces. This is intentional because notifications should generally speaking be global and not workspace specific. We may at some point allow for workspace specific notifications in addition to global notifications.
Related Issues
Checklist
Note
Add the following to FileInspectorView.swift to test