Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Readme on instructions to run pesacheck_meedan_bridge #827

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updates Readme on instructions to run pesacheck_meedan_bridge #827

wants to merge 2 commits into from

Conversation

koechkevin
Copy link
Contributor

Description

This PR updates Pesacheck Meedan bridge with instructions to run and execute the script

Fixes mentioned here

Type of change

Please delete options that are not relevant.

  • Chore (non-breaking change which does not add visible functionality but improves code quality)
  • This change requires a documentation update

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Nov 26, 2024
@koechkevin koechkevin requested a review from a team November 26, 2024 09:51
kilemensi
kilemensi approved these changes Nov 26, 2024
View reviewed changes
pesacheck_meedan_bridge/README.md Outdated
To run `pex` binary, execute:

```sh
docker exec -it ${container_name} ./pex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is ${container_name} name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilemensi can be container name or ID of the running container. I have added a script to readme for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it though? why not just docker compose exec api_pesacheck_meedan_bridge ./pex?

DavidTheProgrammer
DavidTheProgrammer approved these changes Nov 27, 2024
View reviewed changes
Copy link

@DavidTheProgrammer DavidTheProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@DavidTheProgrammer DavidTheProgrammer DavidTheProgrammer approved these changes

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koechkevin @kilemensi @DavidTheProgrammer