Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve queries #61

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Improve queries #61

merged 4 commits into from
Feb 13, 2020

Conversation

karimkawambwa
Copy link
Contributor

Description

  • Calculate data stats in chunks
  • Retrieving stats with more granularity

Continue using the datastat table instead of querying the data values table until we are sure about performance (future proofing). #60

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@karimkawambwa karimkawambwa added bug Something isn't working enhancement New feature or request labels Feb 12, 2020
@karimkawambwa karimkawambwa self-assigned this Feb 12, 2020
kilemensi
kilemensi approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @karimkawambwa

We need to update API docs then: https://github.com/CodeForAfrica/sensors.AFRICA/wiki/APIs#v2

@karimkawambwa karimkawambwa merged commit b2a13af into master Feb 13, 2020
@karimkawambwa karimkawambwa deleted the fix/calculate_data_statistics branch February 13, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

Assignees

@karimkawambwa karimkawambwa

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karimkawambwa @kilemensi