-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ft/Engineering Blog: Render a blog #868
Conversation
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
…nder-blog Signed-off-by: Kipruto <[email protected]>
Will let others look at the code @kelvinkipruto but my vote is on a blog design that uses image sparingly i.e. only when it can improve on words. React, Next.js, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Kipruto <[email protected]>
@koechkevin @DavidTheProgrammer @m453h @thepsalmist @VinneyJ What do you think of @kilemensi comment above, to make it have less images?
|
I think the image quantity is fine. I like I think it looks really nice 🚀 . Looking through the rest of the codebase at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The detail header image looks too large. What do you think of image width being the same size as the centered content? Otherwise, the code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just wondering if we decided against using contentlayer and went for the manual approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Putting an image with each post is alright, but form my observation as @VinneyJ pointed out, the header image when you open a post is too large and might force us to use high-res images (which increases the size of the page), we could take inspiration from Github Blog though we need to think of the standard of images we will be using for each post. We would really need to emphasize on consistency of the images we select. Something like Vercel Blog === |
Finally there!!! Use an image when/if and only when/if it improves the post and it should be part of the content and not decoration. But, I'll let y'all decide. |
Let me remove the image from the single blog page |
Signed-off-by: Kipruto <[email protected]>
…nder-blog Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
…nder-blog Signed-off-by: Kipruto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
This is last sprint's work. Can we get it over the line so folks can start working on this sprint's tasks?
Signed-off-by: Kipruto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Looks good 🚀
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've got enough reviews for us to proceed, no?
Signed-off-by: Kipruto <[email protected]>
Description
This PR enables the rendering of blogs in the engineering blog
Fixes #848 #849
Type of change
Screenshots
Checklist: