Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legislature-tracker fix #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

legislature-tracker fix #1

wants to merge 2 commits into from

Conversation

envythemike
Copy link

New Tabletop.js file update. This update should make the app work again, let me know otherwise.

@ryanvgates
Copy link
Member

I tried to clone your version locally and test it. I used the commands from the instructions. However I still received the following error when I try to open index.html.

TypeError: n.replace is not a function[Learn More]underscore.1.4.3.min.js:1:12240

Are there other steps that I need to do to get it running locally?

@envythemike
Copy link
Author

I forced updated the repo and now it should work now, it does on my github page (I should have tested more thoroughly, never really used github as a host with constraints. Sorry about that).

Problem was api's needed to be called with https not http as a new standard.

https://envythemike.github.io/legislature-tracker/#categories

@ryanvgates
Copy link
Member

@envythemike can you remove the node_modules from the commit? Also, it says under Hacks in the readme

Hacks

Currently, Tabletop.js extends Array so that indexOf is available. This has some implications in browsers, especially in the context of for..in loops. Because of bad code may be in your site that is not easily updatable, we are using a custom version of Tabletop.js. See pull request.

Not sure if that is part of the issue. I'm still getting the same error as before when I try to run it locally.

@envythemike
Copy link
Author

envythemike commented Dec 29, 2016

I forced pushed it this time and try it one more time.
As for the node_modules, I have removed the .gitignore files. Sorry about that!.

I can imagine that the Hacks readme part would imply that that would happen in really old browsers.
Internet Explorer 9 rendering it so that is a good sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants