-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kops #14
base: add-vpc
Are you sure you want to change the base?
Conversation
README.md
Outdated
# Location of previously generationg configuation | ||
# Should be generated using github.com/CodeNow/on-prem-devops-scripts | ||
lc_user_data_file_location = "~/dock-runnable-on-prem.sh" # File must be already generated | ||
# Path to a publick key (See below of generating public key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/publick/public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this, it worked for me!
### Dependencies | ||
|
||
``` | ||
brew install terraform kops jq kubectl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also provide link to install brew.
README.md
Outdated
``` | ||
|
||
### Step 1: Obtaining AWS Access Tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to link to:
http://docs.aws.amazon.com/lambda/latest/dg/getting-started.html
README.md
Outdated
# Access to setting DNS nameservers is required. | ||
# Multiple subdomains must be set for this domain | ||
domain = "runnable.com" | ||
# A Github organization id (See below of obtainig ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/obtainig/obtaining
README.md
Outdated
##### Obtaining A Github ID | ||
|
||
``` | ||
curl -sS "https://api.github.com/orgs/$ORGNAME" | jq '.id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ORGNAME
was not defined anywhere? also stick with one convention in this doc either $ORGNAME
or ${ORGNAME}
### Step 3: Init Terraform and Apply First Part | ||
|
||
``` | ||
terraform init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add cd
step, or tell me what directory I need to be in to run this command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're supposed to run it from this directory... cd ./on-prem-terraform
?
create-k8-cluster.bash
Outdated
--zones="${REGION}a" \ | ||
--name=${CLUSTER_NAME} \ | ||
--vpc=${VPC_ID} \ | ||
--node-count=4 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 not 3?
main.tf
Outdated
force_destroy_s3_buckets = "${var.force_destroy_s3_buckets}" | ||
} | ||
|
||
# Has unfortunate problem of not allowing variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
main.tf
Outdated
cluster_subnet_id = "${module.step_2_kops.node_subnet_ids[0]}" # Currently only handle one subnet for cluster | ||
} | ||
|
||
# Will only be used to access docks. Can we use kops created bastion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still an issue? https://github.com/kubernetes/kops/blob/master/docs/bastion.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, no. Fixed this.
} | ||
|
||
resource "aws_db_instance" "main_postgres_db" { | ||
allocated_storage = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it should be configurable? I don't think it would be much of a problem to have that default, but also easy to fix with variables.
} | ||
} | ||
|
||
resource "aws_autoscaling_group" "dock_auto_scaling_group" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait does this not have shiva running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not have shiva running. This goes back to zendesk not wanting to give us ec2-create permission that shiva needs. We also don't really need shiva because we're only creating one auto-scaling-group (for most use cases). This is a longer discussion though. Can talk offline.
* Create the elastic ip, nat gateway, routing table for docks * Add main gateway * Updated for working plan * NITS
* Udpated readme * Updated readme docs * Fixed bad change * Updated readme
No description provided.