Merge pull request #3 from CodeTogether-Inc/jitsi-extra-check

Add Extra check before setting jitsi url
CodeTogether-Inc · Jan 9, 2024 · 2f1d0ea · 2f1d0ea
2 parents 60cb0fc + 7e05149
commit 2f1d0ea
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/charts/live/Chart.yaml b/charts/live/Chart.yaml
@@ -3,7 +3,7 @@ name: codetogether
 description: CodeTogether Live provides pair programming and collaborative coding
 
 type: application
-version: 1.4.16
+version: 1.4.17
 appVersion: "2023.2.0"
 kubeVersion: ">= 1.18.0"
 

diff --git a/charts/live/templates/deployment.yaml b/charts/live/templates/deployment.yaml
@@ -123,7 +123,7 @@ spec:
                 key: secret
           {{- end }}
 
-          {{- if .Values.av.jitsiUrl }}
+          {{- if and .Values.av.jitsiUrl (ne .Values.av.jitsiUrl \"\") }}
           - name: CT_JITSI_URL
             value: {{ .Values.av.jitsiUrl | quote }}
           {{- end }}

diff --git a/charts/live/values.yaml b/charts/live/values.yaml
@@ -169,6 +169,8 @@ av:
     enabled: false
     server: "coturn.example.com"
     secret: "my-secret"
+  # Optional - Jitsi Settings for locator edge servers with locator or extenral jitsi meet server
+  # jitsiUrl: "https://your.jtsi.server"
 
 #
 # Optionally enable integration with your SSO Provider. If using SSO, this