Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London 10 - Paulina Wywrot - Full Stack Assessment - Level 300 #372

Closed
wants to merge 19 commits into from

Conversation

PaulinaWywrot
Copy link

No description provided.

@PaulinaWywrot PaulinaWywrot changed the title London 10 - Paulina Wywrot - Full Stack Assessment - Level 100 London 10 - Paulina Wywrot - Full Stack Assessment - Level 200 Aug 27, 2023
server/server.js Outdated Show resolved Hide resolved
Copy link

@migmow migmow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PaulinaWywrot - very well-done, great job so far!
A general suggestion would be finding out where you could use useEffect in your React app . Good luck with the next levels! 🥇

@migmow migmow added the Reviewed label Sep 8, 2023
@PaulinaWywrot PaulinaWywrot changed the title London 10 - Paulina Wywrot - Full Stack Assessment - Level 200 London 10 - Paulina Wywrot - Full Stack Assessment - Level 250 Sep 12, 2023
@PaulinaWywrot PaulinaWywrot changed the title London 10 - Paulina Wywrot - Full Stack Assessment - Level 250 London 10 - Paulina Wywrot - Full Stack Assessment - Level 300 Sep 15, 2023
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, nicely put together!

client/src/Components/AddVideo.js Outdated Show resolved Hide resolved
import { useState } from "react";

const VideoCard = ({ video, removeVideo }) => {
const [rating, setRating] = useState(video.rating);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these ratings aren't stored in the database, so if you refresh the page they'll go away, and if multiple users look at the page they won't see each other's ratings. How would you add these to the database so that they're persisted?

server/server.js Outdated Show resolved Hide resolved
PaulinaWywrot and others added 3 commits September 19, 2023 07:06
updated url and status code
Co-authored-by: Daniel Wagner-Hall <[email protected]>
Signed-off-by: PaulinaWywrot <[email protected]>
@PaulinaWywrot
Copy link
Author

PaulinaWywrot commented Sep 19, 2023

Hi @PaulinaWywrot - very well-done, great job so far! A general suggestion would be finding out where you could use useEffect in your React app . Good luck with the next levels! 🥇

Thank you for your comments @ShadiSafaee, I've made some changes to my code :)

updated rating: frontend (videoCard), backend (added put request);
also amended get request (fetch video by id)
@PaulinaWywrot
Copy link
Author

This is looking great, nicely put together!

Hello @illicitonion, thank you for your review. I've implemented some changes as suggested, but please let me know if you have any further suggestions:)

@Dedekind561 Dedekind561 closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants