Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

West Midlands | Gabriel Deng | Module-Data-Flows | Week 1 - Programmer humour #123

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

West Midlands | Gabriel Deng | Module-Data-Flows | Week 1 - Programmer humour #123

wants to merge 3 commits into from

Conversation

gai93003
Copy link

@gai93003 gai93003 commented Jan 5, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@gai93003 gai93003 added the Needs Review Participant to add when requesting review label Jan 5, 2025
@tyzia tyzia added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jan 5, 2025
tyzia
tyzia reviewed Jan 5, 2025
View reviewed changes
Copy link

@tyzia tyzia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you used const to hold api URL. Keep up good work!

@tyzia tyzia added Complete Participant to add when work is complete and review comments have been addressed and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyzia tyzia tyzia left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gai93003 @tyzia