Manchester | Zabihollah Namazi | Module-Data-Flows | challenges | unit-testing | passing-tests #125
Conversation
tyzia
added
the
Review in progress
| Toyota: 0, | ||
| }; | ||
| for(let key in totals){ | ||
| for(let obj in carsSold){ |
There was a problem hiding this comment.
I would suggest to rename obj to something more relevant here. Because for .. in will not iterate over objects in carsSold array. obj will not contain the whole object from this array. It will contain something else.
There was a problem hiding this comment.
car would be better in my opinion
| "Land Rover": 0, | ||
| Toyota: 0, | ||
| }; | ||
| for(let key in totals){ |
There was a problem hiding this comment.
Can you think of a better name for key? Hint: think what it will contain and how you are going to use its value (you will compare it to make from array).
There was a problem hiding this comment.
i think makeCar would be better
|
|
||
| function average(numbers) {} | ||
|
|
||
| let numbers = [4, "-", 8, 11, "hello", "57", 0, 2, "hi", 22]; |
There was a problem hiding this comment.
I can't agree that numbers variable contains array of numbers. Do you? Also, if you are not going to reassign this variable to a new array, what is a better variable type here instead of let?
| } | ||
| } | ||
| console.log(numCount); | ||
| return numCount; |
There was a problem hiding this comment.
It looks to me that you are returning counter (how many numbers you have found in the given array). I think your task is to return average.
| } | ||
|
|
||
| myData = await response.json() | ||
| //console.log(`${JSON.stringify(myData)} this is api`) |
There was a problem hiding this comment.
Please, don't leave commented out code in your final work.
There was a problem hiding this comment.
this commit is a mistake
sorry
|
|
||
| async function fetchData() { | ||
| try{ | ||
| const response = await fetch("https://xkcd.now.sh/?comic=latest") |
There was a problem hiding this comment.
Please, always close your expressions with a semicolon ;
tyzia
added
Reviewed
ZabihollahNamazi
added
Complete
|
Thank you for the update. You can close this PR. |
just ignore the fetch commit please.
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.