Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manchester | Zabihollah Namazi | Module-Data-Flows | challenges | unit testing | writing tests #126

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Manchester | Zabihollah Namazi | Module-Data-Flows | challenges | unit testing | writing tests #126

wants to merge 3 commits into from

Conversation

ZabihollahNamazi
Copy link

just ignore the fetch commit please

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@ZabihollahNamazi ZabihollahNamazi added the Needs Review Participant to add when requesting review label Jan 5, 2025
@ZabihollahNamazi ZabihollahNamazi mentioned this pull request Jan 5, 2025
Open
illicitonion
illicitonion reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like good single unit tests :) In general we try to have more than one unit test for each thing we're testing, can you think why?

Also, I'd recommend undoing the changes you made to the non-test code

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZabihollahNamazi @illicitonion