Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London 11 | Pezhman-Azizi | Data-Flow | Book-Library #129

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

London 11 | Pezhman-Azizi | Data-Flow | Book-Library #129

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24d04f2
debugging/book-library
Pezhman-Azizi Jan 9, 2025
4b53264
Improved input validation and readability:
Pezhman-Azizi Jan 17, 2025
9c378e3
Removed unnecessary id attributes from buttons:
Pezhman-Azizi Jan 17, 2025
eae239a
Improved table rendering:
Pezhman-Azizi Jan 17, 2025
10be17e
Renamed variables for clarity and consistency:
Pezhman-Azizi Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 35 additions & 41 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,25 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1, book2);
render();
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
Expand All @@ -37,8 +32,8 @@ function submit() {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
}
}
Expand All @@ -53,35 +48,33 @@ function Book(title, author, pages, check) {
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;

//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a more efficient way to remove all rows (except the heading) in the table?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve replaced the for loop with a more efficient approach by resetting the tbody directly. This clears all rows except the heading in a single operation, reducing DOM manipulations and improving performance. Let me know if you have further thoughts!


//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
for (let i = 0; i < myLibrary.length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
let cell1 = row.insertCell(0);
let cell2 = row.insertCell(1);
let cell3 = row.insertCell(2);
let cell4 = row.insertCell(3);
let cell5 = row.insertCell(4);

cell1.innerHTML = myLibrary[i].title;
cell2.innerHTML = myLibrary[i].author;
cell3.innerHTML = myLibrary[i].pages;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rewrite these statements with "less informative" variable names?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the following improvements based on your suggestions:

Removed the redundant == null checks since input .value is never null.
Added .trim() to handle whitespace-only inputs for title and author.
Improved the validation for pages to ensure it’s a positive whole number.
Replaced generic variable names like cell1 with more descriptive ones (e.g., titleCell).
Updated alert messages to give clearer instructions when inputs are invalid.


//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
cell4.appendChild(changeBut);

let readStatus = myLibrary[i].check ? "Yes" : "No";
changeBut.innerHTML = readStatus;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Inconsistent variable names) Why name one variable changeBut but the other delButton?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed the variables to maintain consistent and descriptive naming. changeBut is now readButton, and delButton is now deleteButton. This makes the code clearer and aligns the naming with their respective functionalities


changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
Expand All @@ -90,11 +83,12 @@ function render() {

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delButton.id = i + 5;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do you think the value assigned to the id attribute is unique?
  • Do you think there is a need to assign any id attribute to delButton?
  • Do you think there is a need to assign any id attribute to changeBut at line 72?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out! I've made the following improvements based on your feedback:

Removed unnecessary id attributes from delButton and changeBut since they weren't being used anywhere.
Simplified the logic by relying on the loop index (i) for context, which avoids potential ID conflicts and makes the code cleaner.
Updated the button logic to be more concise and easier to follow.

cell5.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";

delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down