West Midlands | Danial Bashirzadeh | Module-Data-Flows | sprint1 | Destructuring #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashirzadehdanial
added
the
Needs Review
|
|
||
| const itemTotal = quantity * unitPricePence; | ||
| total += itemTotal; | ||
| console.log(`${quantity.toString().padEnd(8)}${itemName.padEnd(20)}${(itemTotal/100).toFixed(2)}`); |
There was a problem hiding this comment.
If you changed one of these numbers (e.g. made itemName pad to 25 instead of 20), you'd have to change another line of code a well.
Can you think how you can make it so that if you changed one of these numbers, you wouldn't need t ochange anything else?
There was a problem hiding this comment.
Thanks, Daniel for the valuable feedback. You are right, I can use a constant or variable to define the padding values, instead.
There was a problem hiding this comment.
You're currently only using the values 8 and 20 in one place, so I don't think a constant or variable would help here? That would only help if you were writing down 8 and 20 in multiple places...
illicitonion
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.