CYF-Glasgoow | Iakub Dubachev | Book Library | Sprint 2 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shieldo
approved these changes
Jan 11, 2025
| deleteCell.appendChild(delButton); | ||
|
|
||
| delButton.addEventListener("click", function () { | ||
| alert(`You've deleted title: ${book.title}`); |
There was a problem hiding this comment.
A really small thing is that I would show this alert after you have performed the re-render - this would probably be less surprising for a user!
This is good work, though! I like the way that you have introduced ternary expressions, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Fixed book list not displaying on page load.
Corrected author field assignment and added input validation in submit().
Fixed delete button functionality (clicks → click).
Corrected read status display logic (Yes/No).
Improved table rendering to handle dynamic updates.
Added clearForm() to reset input fields after adding a book.
Questions
Are there any additional edge cases I should test?
Any recommendations for improving DOM updates or event handling?