Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

West-Midlands-Community | Matthew Law | Module-Data-Flows | WEEK 11 | Book Library #143

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

West-Midlands-Community | Matthew Law | Module-Data-Flows | WEEK 11 | Book Library #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b65254a
script.js - fixed listed bugs
rawrnoodles Jan 13, 2025
0b6204b
script.js - moved alert for delete button after the book is deleted.
rawrnoodles Jan 17, 2025
2883407
script.js - removed ids' and used dataset.index instead
rawrnoodles Jan 17, 2025
95a7ff8
index.html - made fixes to index.html
rawrnoodles Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 51 additions & 88 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,59 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<head>
<title>Library</title>
<meta charset="utf-8" name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input type="text" class="form-control" id="title" name="title" required />

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<label for="author">Author:</label>
<input type="text" class="form-control" id="author" name="author" required />

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
<label for="pages">Pages:</label>
<input type="number" class="form-control" id="pages" name="pages" required />

<label for="read-checkbox" class="form-check-label">
<input type="checkbox" class="form-check-input" id="read-checkbox" /> Read
</label>

<input type="submit" value="Submit" class="btn btn-primary" onclick="submit();" />
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody></tbody>
</table>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<script src="script.js"></script>
</body>

<script src="script.js"></script>
</body>
</html>
</html>
107 changes: 45 additions & 62 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,36 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
if (myLibrary.length === 0) {
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true);
myLibrary.push(book1, book2);
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const check = document.getElementById("read-checkbox");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
if (!title.value || !author.value || !pages.value) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
if (isNaN(pages.value) || pages.value <= 0) {
alert("Please enter a valid number of pages!");
return false;
}

let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
Expand All @@ -53,51 +43,44 @@ function Book(title, author, pages, check) {
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {

// Delete old rows
for (let n = rowsNumber - 1; n > 0; n--) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a more efficient way to remove all rows (except the elements) in the table. The entire can be cleared in a single operation by setting its innerHTML to an empty string.

table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
// Insert updated rows
for (let i = 0; i < myLibrary.length; i++) {
let row = table.insertRow(-1);

row.insertCell(0).innerText = myLibrary[i].title;
row.insertCell(1).innerText = myLibrary[i].author;
row.insertCell(2).innerText = myLibrary[i].pages;

changeBut.addEventListener("click", function () {
let wasReadCell = row.insertCell(3);
let toggleButton = document.createElement("button");
toggleButton.dataset.index = i;
toggleButton.className = "btn btn-success";
toggleButton.innerText = myLibrary[i].check ? "Yes" : "No";
toggleButton.addEventListener("click", function () {
const index = this.dataset.index;
myLibrary[i].check = !myLibrary[i].check;
render();
});
wasReadCell.appendChild(toggleButton);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
let deleteCell = row.insertCell(4);
let deleteButton = document.createElement("button");
deleteButton.dataset.index = i;
deleteButton.className = "btn btn-warning";
deleteButton.innerHTML = "Delete";
deleteButton.addEventListener("click", function () {
const index = this.dataset.index;
const removedTitle = myLibrary[index].title;
myLibrary.splice(index, 1);
render();
alert(`You've deleted title: ${removedTitle}`);
});
deleteCell.appendChild(deleteButton);
}
}
}