Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WM4 | FATIMA_SAFANA | MODULE-DATA-GROUPS | WEEK3 | ALARMCLOCK #270

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WM4 | FATIMA_SAFANA | MODULE-DATA-GROUPS | WEEK3 | ALARMCLOCK #270

wants to merge 3 commits into from

Conversation

Fatimasfn
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Fatimasfn Fatimasfn added the Needs Review Participant to add when requesting review label Jan 1, 2025
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 14, 2025
cjyuan
cjyuan reviewed Jan 14, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code works fine if a user only clicks the "Set Alarm" button once.
    If the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
    Can you fix the problem?

  • After the user clicks the "Set Alarm" button, there is a one second delay before the countdown clock starts showing. Can you find a way to "remove" that delay?

  • I think you misinterpreted an instruction in readme.md. You should only need to change something in index.html, not renaming the file.

Sprint-3/alarmclock/alarmclock.js Outdated Show resolved Hide resolved
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 14, 2025
@Fatimasfn Fatimasfn added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fatimasfn @cjyuan