London 11 | Pezhman-Azizi | Data-Groups | sprint 3 | Quote Generator #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roduced new modern teal-grey theme for a fresh, clean look. Ready for feedback or further refinements!
…extEncoder polyfill and ensuring Jest and jsdom configurations were correctly set up. All tests are now passing successfully!
cjyuan
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Code is good. Feel free to mark this as "Completed".
-
We should respect instructions like
DO NOT EDIT BELOW HERE; it is usually there for a good reason. If you are curious about why, you can ask ChatGPTWhy should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file? -
I won't be able to answer your questions regarding "TextEncoder" because I didn't run
jeston this app, and I do not know what issue you were referring to.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this update, I implemented functionality for the Quote Generator to display a random quote and author on page load, with a button to generate new quotes when clicked. The styling was enhanced with a modern teal and grey color scheme, responsive layout, and interactive button effects. I also fixed compatibility issues in the tests by adding a TextEncoder polyfill, updated Jest and jsdom configurations, and ensured all tests passed successfully. The project structure was organized for better readability and maintainability.
Questions
I encountered and resolved the TextEncoder issue during the tests with the help of a polyfill. Could you confirm if my understanding is correct—that the issue arose because Node.js needed TextEncoder globally available for jsdom? I want to ensure I’ve grasped it fully.