SOUTH AFRICA CPT-ITP | LUKE MANYAMAZI | MODULE DATA GROUPS | SLIDE SHOW | WEEK 3

[Luke-Manyamazi]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[halilibrahimcelik]

Excellent work! You've successfully implemented all the requirements outlined in the README file. While styling wasn't a primary focus, I must commend your clean and thoughtful approach. The carousel, complete with hover effects, is well-executed and visually appealing.

Here's a challenge for you: consider adding a feature that pauses the sliding animation when the user hovers over the slides. This would enhance user interaction and make your implementation even more dynamic.

[halilibrahimcelik]

It is a common practice that while selecting your html elements, it is better to organize them at the beginning of your script. You defined your img element at the beginning, also define other elements at the same place.

[Luke-Manyamazi]

Thank you! I will work on the challenge.

…

On Wed, Jan 8, 2025 at 11:33 PM Halil Ibrahim Celik < ***@***.***> wrote: ***@***.**** approved this pull request. Excellent work! You've successfully implemented all the requirements outlined in the README file. While styling wasn't a primary focus, I must commend your clean and thoughtful approach. The carousel, complete with hover effects, is well-executed and visually appealing. Here's a challenge for you: consider adding a feature that pauses the sliding animation when the user hovers over the slides. This would enhance user interaction and make your implementation even more dynamic. ------------------------------ In Sprint-3/slideshow/slideshow.js <#278 (comment)> : > + slideIndex = images.length - 1; + } else { + slideIndex = index; + } + imgElement.src = images[slideIndex]; + updateDots() +} + +function updateDots() { + for (let i = 0; i < dots.length; i++) { + dots[i].className = dots[i].className.replace(" active", ""); + } + dots[slideIndex].className += " active"; +} + +document.querySelector('.prev').addEventListener('click', () => { It is a common practice that while selecting your html elements, it is better to organize them at the beginning of your script. You defined your img element at the beginning, also define other elements at the same place. — Reply to this email directly, view it on GitHub <#278 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLZ6TQHXO2O3LS4Z4KUNCLT2JWKTFAVCNFSM6AAAAABUXUWIJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZYGMZDGNJTGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>