Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYF London | Rihanna Poursoltani | Module-Data-Groups | Sprint 1 #281

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CYF London | Rihanna Poursoltani | Module-Data-Groups | Sprint 1 #281

wants to merge 4 commits into from

Conversation

RihannaP
Copy link

@RihannaP RihannaP commented Jan 8, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@RihannaP RihannaP added the Needs Review Participant to add when requesting review label Jan 8, 2025
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 10, 2025
cjyuan
cjyuan reviewed Jan 10, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is very solid. I only have a few comments and suggestions.

Sprint-1/fix/median.js Outdated Show resolved Hide resolved
Sprint-1/fix/median.js Outdated Show resolved Hide resolved
Sprint-1/implement/dedupe.test.js Outdated Show resolved Hide resolved
Sprint-1/implement/dedupe.test.js Outdated Show resolved Hide resolved
Sprint-1/implement/max.test.js Outdated Show resolved Hide resolved
Sprint-1/implement/sum.test.js Outdated Show resolved Hide resolved
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 10, 2025
@RihannaP RihannaP added the Complete Participant to add when work is complete and review comments have been addressed label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RihannaP @cjyuan