CYF-ITP-South Africa | Serna Malala | Module-Data-Groups | Week 3 Reading List Display #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Jan 14, 2025
Comment on lines
+31
to
+32
| const title = document.createElement("h2"); | ||
| const author = document.createElement("h3"); |
There was a problem hiding this comment.
How do you determine title is level 2 heading and author is level 3 heading?
Have you considered marking them as <div class="title"> and <div class="author"> and then use CSS to style the them accordingly?
There was a problem hiding this comment.
hmm well I did not really think that out to be honest, knowing the rules with using headings I should have used a different element
Comment on lines
+41
to
+44
| readingList.style.textAlign = "center"; | ||
| div.style.backgroundColor = colour; | ||
| div.style.maxWidth = "500px"; | ||
| image.style.width = "200px"; |
There was a problem hiding this comment.
Why not style these elements in style.css?
There was a problem hiding this comment.
I wanted to play around with the DOM manipulation in javascript but yes, those can definitely be hardcoded in the CSS
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I added code that will render the books onto the screen dynamically using javascript and DOM manipulation
Questions
Ask any questions you have for your reviewer.