-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6| Bakhat Begum|Module-JS1|Bakhat/week 1|sprint-1|week-1 #136
base: main
Are you sure you want to change the base?
Conversation
Hello, I just finished reviewing your code, I hope it makes sense. This is the link to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Bakhat, I hope this message finds you well. I wanted to take a moment to acknowledge and comment on your recent coding work. you did a great job. I really love the neatness of your code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can easily change the variable's value to a string by adding quotation marks, like this: "3.467t34378".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use % 1, you can easily obtain the decimal number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code doesn't need the .slice syntax since it's already using charAt(0) to get the initial character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const extPart = filePath.slice(filePath.lastIndexOf(".") + 1);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Math.random() always gives a number in the range [0,1), which is a decimal number. Multiply it by (max - min + 1) and use Math.floor to get a number in the range [0, 99). When you add 1, the result will be [1, 100].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are 4 functions: 2 replaceAll and 2 Number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 7 variable declarations and 0 function calls.
The link you are provided is a part of active listening we do not need it in Google Docs. Second, whatever you wrote in the comment area itself is feedback. |
It was a great programming language, and I have learned some code through this repo.