-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6 | Hadika Malik | Module JS1 | Week 1 + 2 #150
base: main
Are you sure you want to change the base?
NW6 | Hadika Malik | Module JS1 | Week 1 + 2 #150
Conversation
I love your coding style! Your code is always so clear and easy to understand. I can follow and understand them easily. Keep up the great work! |
@@ -11,10 +11,10 @@ console.log(`The percentage change is ${percentageChange}`); | |||
|
|||
// Read the code and then answer the questions below | |||
|
|||
// a) How many function calls are there in this file? Write down all the lines where a function call is made | |||
// a) How many function calls are there in this file? Write down all the lines where a function call is made - line 4,5,8,10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've identified 3 calls correctly. What's the function that's called on line 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. Is line 8 not a function call?
Week 1 overall feedback I've left a few comments to work on. I'm also curious to know if you attempted the chrome exploration task(week-1/explore/chrome.md)? I'll have a look at week 2 shortly |
Week 2 overall feedback To take this to the next level, start thinking about how easy you make it for other developers to read your code. Particularly, think about how you name variables and functions - try to be very clear and descriptive. Overall, good work on these exercises 👏 |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I have completed both week 1 and week 2 exercises but when pushing it from vs to git it accidentally pushed to week 2 which includes my week 1 exercise
Questions
Ask any questions you have for your reviewer.