Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6 | Hadika Malik | Module JS1 | Week 1 + 2 #150

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HadikaMalik
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
I have completed both week 1 and week 2 exercises but when pushing it from vs to git it accidentally pushed to week 2 which includes my week 1 exercise

Questions

Ask any questions you have for your reviewer.

@zelihapala
Copy link

I love your coding style! Your code is always so clear and easy to understand. I can follow and understand them easily. Keep up the great work!

week-1/exercises/paths.js Outdated Show resolved Hide resolved
week-1/exercises/random.js Outdated Show resolved Hide resolved
@@ -11,10 +11,10 @@ console.log(`The percentage change is ${percentageChange}`);

// Read the code and then answer the questions below

// a) How many function calls are there in this file? Write down all the lines where a function call is made
// a) How many function calls are there in this file? Write down all the lines where a function call is made - line 4,5,8,10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've identified 3 calls correctly. What's the function that's called on line 8?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. Is line 8 not a function call?

@varuna-v
Copy link

varuna-v commented Dec 9, 2023

Week 1 overall feedback
Great work on the exercises, Hadika. You have clearly demonstrated an ability to interpret Javascript and follow the flow of the code.

I've left a few comments to work on. I'm also curious to know if you attempted the chrome exploration task(week-1/explore/chrome.md)?

I'll have a look at week 2 shortly

week-2/errors/0.js Outdated Show resolved Hide resolved
week-2/implement/cases.js Outdated Show resolved Hide resolved
@varuna-v
Copy link

varuna-v commented Dec 9, 2023

Week 2 overall feedback
You have developed the skills of reading, understanding, and implementing Javascript code. This creates a really good foundation as you begin to tackle more difficult programming problems.

To take this to the next level, start thinking about how easy you make it for other developers to read your code. Particularly, think about how you name variables and functions - try to be very clear and descriptive.

Overall, good work on these exercises 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants