NW-6 | AREEB-SATTAR | JS1| [TECH ED] Complete week 3 exercises | WEEK-3 #154
Conversation
| @@ -1,6 +1,10 @@ | |||
| function formatAs12HourClock(time) { | |||
| if (Number(time.slice(0, 2)) > 12) { | |||
| return `${Number(time.slice(0, 2)) - 12}:00 pm`; | |||
| let timeFormat = (Number(time.slice(0, 2)) - 12) | |||
| if (timeFormat <10 ) | |||
There was a problem hiding this comment.
Can you think of a way this can be done without an if statement? JavaScript's standard library has a great function for this use case 😉
week-3/implement/get-angle-type.js
Outdated
There was a problem hiding this comment.
Nice job writing if statements that are in a working order Areeb! Only thing I'd do is swap the statements on lines 27 and 30. That way all of the angles would be in ascending order (i.e., <90 would come before ===90).
week-3/refactor/is-vowel.js
Outdated
There was a problem hiding this comment.
Fantastic! Adding a test specifically the code being changed is a great way to make sure it still works after the refactoring!
| // I already stored it in a variable in first problem because we are using same thing twice which can make code look | ||
| // confusing and by storing it in variable it makes things easier for someone unfamiliar with code to understand. | ||
| function formatAs12HourClock(time) { | ||
| if (Number(time.slice(0, 2)) > 12) { |
There was a problem hiding this comment.
I think we can take this further. What if we moved the expression Number(time.slice(0, 2)) into a variable after line 9, then use that variable in the if statement and line 11. By also giving the variable a name such as hours, it would be easier to glance at the code and tell what is happening in the logic.
| else if (a<=0 || b<=0 || c<=0){ | ||
| return false; | ||
| } | ||
| else if(a+b>c && a+c>b && b+c>a){ |
There was a problem hiding this comment.
This logic here is the opposite of the logic on line 43. For example, a + b <= c must be false for us to reach this line of code. Therefore a + b > c will always be true at line 49. The same goes for the other statements.
For that reason the checks here on line 49 aren't necessary
| return false; | ||
| } | ||
| else if (b=0){ | ||
| return ; |
There was a problem hiding this comment.
Is this missing a return value?
| @@ -29,3 +29,46 @@ | |||
| // Given a card with an invalid rank (neither a number nor a recognized face card), | |||
| // When the function is called with such a card, | |||
| // Then it should throw an error indicating "Invalid card rank." | |||
|
|
|||
| function getCardValue(str) { | |||
There was a problem hiding this comment.
Be careful of the acceptance criteria on line 9. str might be a value such as A♠, which contains both the card suit and value
| else if (angle>180 && angle<360){ | ||
| return "Reflex Angle" | ||
| } | ||
| else |
There was a problem hiding this comment.
an angle of 360 itself is not taken care of
| @@ -33,3 +35,39 @@ | |||
| // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false. | |||
|
|
|||
| // These acceptance criteria cover a range of scenarios to ensure that the isProperFraction function handles both proper and improper fractions correctly and handles potential errors such as a zero denominator. | |||
|
|
|||
| function isProperFraction(a, b) { | |||
There was a problem hiding this comment.
what do you think will happen when we pass 3/-5 into your code?
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I have completed the exercises except stretch here yet
Questions
Ask any questions you have for your reviewer.
I am not sure if these are the best way to implement them or if they can be improved further