NW6 | Pedro Ricciardi | JS1 Module | [TECH ED] Complete week 3 exercises | Week 3 Backlog #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I really like what you've done. A comment I started making and then realised I'd have to repeat it a lot of times, so stopped, is that a lot of the time you are using else when you don't really need to. This is a style point rather than a functional change, but you will probably find your code more readable in the long term if you treat else with suspicion and ask yourself if you really need it.
…e last if else from the function
…cludes method to check the vowel inside an array
5 tasks
bunday
suggested changes
Dec 9, 2023
| @@ -21,3 +21,37 @@ | |||
| // Identify Reflex Angles: | |||
| // When the angle is greater than 180 degrees and less than 360 degrees, | |||
| // Then the function should return "Reflex angle" | |||
|
|
|||
| function getAngleType(angle) { | |||
| if (angle >= 360 || angle <= 0) { | |||
| @@ -29,3 +29,46 @@ | |||
| // Given a card with an invalid rank (neither a number nor a recognized face card), | |||
| // When the function is called with such a card, | |||
| // Then it should throw an error indicating "Invalid card rank." | |||
|
|
|||
| function getCardValue(card) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
All tasks done. Implemented assertions, improved code using a function to create an assertion pattern, used methods to manipulate strings and numbers, used 'switch' instead of 'if' for cleaner code, used methods to check data type, and worked with Unicode characters.