NW6| FIDAA BASHIR | Module-JS1 | WEEK2 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ara225
reviewed
Dec 6, 2023
| @@ -5,3 +5,7 @@ function multiply(a, b) { | |||
| } | |||
|
|
|||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); | |||
|
|
|||
| //The first line of the function logs the product of the two arguments to the console. The second line of the code calls the multiply() function with the arguments 10 and 32, and then logs the result to the console. The expected output is: | |||
| } | ||
|
|
||
| console.log(`The sum of 10 and 32 is ${sum(10, 32)}`); | ||
|
|
||
| //the error here that we should place the a + b expression directly after the return keyword. |
There was a problem hiding this comment.
This is true, I would probably word it a bit differently - the problem is that the function returns nothing - the line below return is never executed.
| function getLastDigit() { | ||
| return num.toString().slice(-1); | ||
| function getLastDigit(num) { | ||
| return num % 10; |
There was a problem hiding this comment.
This is a clever solution. No one else I've seen has done this. It does have a small bug, though, if we change the inputs a bit. Also if possible some more explanation would be great
| @@ -4,6 +4,7 @@ | |||
| // interpret the error message and figure out why it's happening, if your prediction was wrong | |||
|
|
|||
| function capitalise(str) { | |||
| let str = `${str[0].toUpperCase()}${str.slice(1)}`; | |||
| str = `${str[0].toUpperCase()}${str.slice(1)}`; | |||
| @@ -2,12 +2,14 @@ | |||
| // Write down the error you predict will be raised | |||
| // Why will an error occur when this program runs? | |||
| // Play computer with the example to work out what is going on | |||
| //In this code, there is an error that the variable decimalNumber, declared twice. once as a parameter of the convertToPercentage function and again outside the function, because in JS variables can't be declared twice within the same scope | |||
| // to fix this error, we need to delete the parameter in line 8, so we can call the function without any argument. | |||
Comment on lines
+16
to
+21
|
|
||
| function calculateBMI(weight, height) { | ||
| const BMI = weight / (height * height); | ||
| return BMI.toFixed(1); | ||
|
|
||
| } |
| // Come up with a clear, simple name for the function | ||
| // Use the string documentation to help you plan your solution | ||
|
|
||
| function camelCaseToWords(text) { |
There was a problem hiding this comment.
This is a great little function, well done. For next time, I'd probably name it differently, functions rend to get named something g like convertToUpperCamelCase() but this is a mere niggle
Comment on lines
+6
to
+13
|
|
||
| function toPounds(penceString) { | ||
| const penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1); | ||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); | ||
| const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2); | ||
| const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"); | ||
| return `£${pounds}.${pence}`; | ||
| } |
There was a problem hiding this comment.
Looking good, appreciate the descriptive var names!
| @@ -8,3 +8,11 @@ | |||
| // Given a number, | |||
| // When I call this function with a number | |||
| // Then it returns the new price with VAT added on | |||
|
|
|||
| function calculatePriceWithVAT(price) { | |||
| price = price * 1.2; | |||
There was a problem hiding this comment.
Works, Could just do return price * 1.2; here - this line isn't strictly necessary
| //we can use padStart(2, '0') to pad the numbers to a length of two characters with the padding character '0'. like this: | ||
| //function pad(num) { | ||
| //return num.toString().padStart(2, '0'); | ||
| //} |
There was a problem hiding this comment.
All amazing here no faults that I can find, well done 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I worked on the JS1 module exercises
Questions
Ask any questions you have for your reviewer.