NW6| FIDAA BASHIR | Module-JS1 | WEEK3 #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 14, 2023 21:39
pedram-am
reviewed
Dec 19, 2023
| // a) Write an assertion to check the return value of formatAs12HourClock when it is called with an input "17:42" | ||
| // b) Check the assertion output and explain what the bug is | ||
| // c) Now fix the bug and re-run all your assertions | ||
| console.log(formatAs12HourClock("11:00")); |
There was a problem hiding this comment.
Well done! We can also try different cases using console.log to make sure that the code works properly for any kind of input.
| console.log(getAngleType(120)); | ||
| console.log(getAngleType(180)); | ||
| console.log(getAngleType(200)); | ||
| console.log(getAngleType(540)); |
There was a problem hiding this comment.
Perfect! 👍 That's great you considered the invalid inputs as well, to return invalid angles!
| throw new Error("Invalid card rank."); | ||
| } | ||
| } | ||
| console.log(getCardValue(10)); |
There was a problem hiding this comment.
Great attempt to implement the function! Try to run your code again and find out how to fix the error if it gives you any error! We also need to write assertions using console.assert as the exercise asks us to do, in line 5!
| console.assert(isProperFraction(-4, 7) === true, "Test Case 4 Failed"); // Negative Fraction check | ||
| console.assert(isProperFraction(3, 3) === false, "Test Case 5 Failed"); // Equal Numerator and Denominator check | ||
|
|
||
| console.log("All assertions passed!"); |
There was a problem hiding this comment.
That's correct! All the assertions you wrote, passed! Great job! 👍
| @@ -38,3 +38,12 @@ | |||
| // Then it should return true because the input forms a valid triangle. | |||
|
|
|||
| // This specification outlines the behavior of the isValidTriangle function for different input scenarios, ensuring it properly checks for invalid side lengths and whether they form a valid triangle according to the Triangle Inequality Theorem. | |||
|
|
|||
| function isValidTriangle(a, b, c) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.