WM5 | Karam Ali | Module-JS1 | Week 2 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayali436
changed the title
| // This is just an instruction for the first activity - but it is just for human consumption | ||
| // We don't want the computer to run these 2 lines - how can we solve this problem? |
| const cityOfBirth = "Bolton"; | ||
| console.log(`I was born in ${cityOfBirth}`); |
| const twelveHourClockTime = "20:53"; | ||
| const twentyFourHourClockTime = "08:53"; | ||
|
|
AltomHussain
reviewed
Nov 4, 2023
week-2/implement/to-pounds.js
Outdated
|
|
||
| console.log(toPounds("499p")); | ||
| console.log(toPounds("293p")); | ||
| console.log(toPounds("27p")); |
Ara225
reviewed
Nov 4, 2023
| // Then when we call this function with the weight and height | ||
| // It should return their Body Mass Index to 1 decimal place | ||
|
|
||
| function bodyMassIndex(height, weight) { |
Honestocean
reviewed
Nov 4, 2023
| @@ -25,12 +25,37 @@ console.log(formatTimeDisplay(143)); | |||
|
|
|||
| // Questions | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
you seen to have this left over from a merge conflict!
| @@ -25,12 +25,37 @@ console.log(formatTimeDisplay(143)); | |||
|
|
|||
| // Questions | |||
|
|
|||
| <<<<<<< HEAD | |||
| // a) Run this program with node, identify the line the error is thrown. Explain why this error is occurring. How can you fix this error? | |||
There was a problem hiding this comment.
This answer seems to be from elsewhere?
| // a) When formatTimeDisplay is called how many times will pad be called? | ||
|
|
||
| // Call formatTimeDisplay with an input of 143, now answer the following: | ||
| >>>>>>> 03fce56db903fb986ff36f73e4d57cebfa18707c | ||
|
|
||
| // b) What value is assigned to the parameter num when pad is called for the first time? |
There was a problem hiding this comment.
you need to write an answer for this question!
|
|
||
| // b) What value is assigned to the parameter num when pad is called for the first time? | ||
|
|
||
| <<<<<<< HEAD | ||
| // c) What is the value assigned to num when pad is called for the first time? | ||
| // remainingHours |
There was a problem hiding this comment.
what is the value of remainingHours?
AltomHussain
reviewed
Nov 4, 2023
| const percentage = `${decimalNumber * 100}%`; | ||
|
|
||
| return percentage; | ||
| } | ||
|
|
||
| console.log(decimalNumber); | ||
|
|
||
| console.log(convertToPercentage(0.7)); |
There was a problem hiding this comment.
What you did here is correct, however, you need to declare decimalNumber as a var and assign 0.7 to it, and then pass the "decimalNumber" into the function convertToPercentage instead of passing 0.7 straight.
|
|
||
| console.log(square(3)); | ||
| console.log(square(2)); | ||
| console.log(square(4)); |
AltomHussain
reviewed
Nov 4, 2023
|
|
||
| console.log(toPounds("499p")); | ||
| console.log(toPounds("293p")); | ||
| console.log(toPounds("27p")); |
bunday
suggested changes
Nov 4, 2023
|
|
||
| function priceWithVAT(price) { | ||
| newPrice = price * 1.2; | ||
| return `New price (20% VAT inclusive): £${newPrice}`; |
There was a problem hiding this comment.
Ideally, this should just return a number called newPrice without any string/text before to it.
| function multiply(a, b) { | ||
| console.log(a * b); | ||
| return a * b; | ||
| } | ||
|
|
||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); |
| const myNameCapTest = capitalise("karam"); | ||
|
|
||
| console.log(capitaliseTest); | ||
| console.log(myNameCapTest); |
| return `£${(Number(str.substring(0, str.length - 1)) / 100).toFixed(2)}`; | ||
| } | ||
|
|
||
| console.log(toPounds("499p")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Changelist
Briefly explain your PR.
My completed exercises
Questions
Ask any questions you have for your reviewer.