This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
NW-6 | AREEB-SATTAR | JS2| [TECH ED] Alarm Clock | WEEK-3 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
JayMayer
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Great work Areeb! I like your use of the global scope to keep everything in sync, and I'm really happy that we got to discuss clearInterval(..) in class as well.
Your code is simple and clear to read, well done! 🎊
The only comment from me is to check where you might be able to use const instead of let to make sure you (or someone editing your code) doesn't accidentally change the value 🔒
|
It was helpful to have that discussion in class for sure. I try to use const more often now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created the alarm clock app as per requirments
Questions