NW-6 | AREEB-SATTAR | JS2| [TECH ED] Slideshow| WEEK-4 #224
Conversation
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| autoIntervalID = setInterval(backward, 2500); | ||
| }); | ||
| autoForwardBtn.addEventListener("click", () => { |
There was a problem hiding this comment.
consider what happens when the atuoforward button is clicked multiple times
There was a problem hiding this comment.
Overall, your code is easy to follow and understand. You have written clean, concise, readable code which can be maintained and can be updated accordingly later on.
You could however, add comments to expain the purpose and functunality of some of the code to improve the reability.
| <button type="button" id="stop-btn">Stop</button> | ||
| <button type="button" id="forward-btn">Forward</button> | ||
| <button type="button" id="auto-forward-btn">Auto Forward</button> | ||
| </section> |
There was a problem hiding this comment.
The code is clean, concise and readable. The unique ID's you have given to buttons is thoughful and can simplify the development process and make the code more maintainable in the future.
| carouselImages.src = images[currentIndex]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Your code follows consistent naming conventions which is easy to follow and understand.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.