ITP-JAN-25 | FOROGH AGHAEIYARIJANI | ONBOARDING| WEEK2-SPRINT2- CreatFormControl #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forogh-Aghaeiyarijani
added
the
Needs Review
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <label for="name">What is the customer's name?</label> |
There was a problem hiding this comment.
You need to require at least 2 characters for the name.
There was a problem hiding this comment.
Thank you so much for reviewing my code. I did it.
There was a problem hiding this comment.
Thanks. I did it again.
Waldo-Strydom
added
👀 Review Requirements
|
The Name field is still accepting a single character. Please try a different solution. |
|
Good job |
Waldo-Strydom
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.