ITP-JAN-2025 | NW | Jovy So | Form controls | WEEK 2 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -4,24 +4,56 @@ | |||
| <meta charset="utf-8" /> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | |||
| <title>My form exercise</title> | |||
| <meta name="description" content="" /> | |||
| <meta name="description" content="My form exercise" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |||
There was a problem hiding this comment.
You need to get 100 accessibility score. Please fix.
Touch targets do not have sufficient size or spacing.
| <h2>Please enter following information</h2> | ||
|
|
||
| <form> | ||
| <label for="fname">First name:</label><br> |
There was a problem hiding this comment.
All the fields need to be required. The name needs to be at least 2 char long and the email needs to be validated.
Waldo-Strydom
added
👀 Review Requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.