ITP-JAN-25- LONDON | KEBROM-GEBRETINSAY | Module-Onboarding - Wireframe | WEEK 1 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kbtesfu
changed the title
|
Please add labels. |
|
Please add your cohort name e.g South Africa to your PR Titles. |
kbtesfu
changed the title
The label button is inactive, (none yet) |
Wireframe/index.html
Outdated
| <p> It's a graphic representation of a website, | ||
| mobile app or other digital interface that highlights the overall structure and | ||
| layout of the design without going into specifics like colors, fonts or images.</p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Please use your own images, texts colors etc.
Wireframe/index.html
Outdated
| </main> | ||
| <section> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| Explore how Wireframing can streamline your design process and improve collaboration. | ||
| </p> | ||
| </footer> |
There was a problem hiding this comment.
You can make your footer more distinguish by adding e.i different bg-color. So that people understand that part constitutes a footer block,
There was a problem hiding this comment.
I made some changes based on reviews.
|
Well done. |
Waldo-Strydom
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.