Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITP_JAN_25 / YORSALEM MESMER / Module-Onboarding / Week 1 #222

Closed
wants to merge 10 commits into from
Closed

ITP_JAN_25 / YORSALEM MESMER / Module-Onboarding / Week 1 #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
01ac17c
chenge title
Jerry-yorsalem Jan 18, 2025
c68780b
I made some chenges on css
Jerry-yorsalem Jan 28, 2025
052c241
Add structure on Html
Jerry-yorsalem Jan 28, 2025
b0dbece
Change img
Jerry-yorsalem Jan 28, 2025
bca8756
I have made all recommendation
Jerry-yorsalem Jan 28, 2025
565f69b
I change the url file to a descriptive text inside the alt attribute.
Jerry-yorsalem Jan 29, 2025
9fd6c1e
I add a background colour to the footer.
Jerry-yorsalem Jan 29, 2025
62da588
I added a link to the Read more.
Jerry-yorsalem Jan 29, 2025
dd9904e
I removed div from html file to fix my accessibility score.
Jerry-yorsalem Jan 30, 2025
fbbb9f4
The inspect outcome of lighthouse is 100%
Jerry-yorsalem Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Wireframe/image.png/OIP.jfif
View file
Open in desktop
Binary file not shown.
Binary file added Wireframe/image.png/Readme1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/image.png/What-is-Wireframing.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
86 changes: 58 additions & 28 deletions Wireframe/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,63 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
</p>
</header>
<main>
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
</head>

<body>
<header>
<h1> Helpfull Sites Like Readme file, Wireframe and Git</h1>
<p>
This gudie provides a comprehensive overview of three essential tools in softwear
development and design. Learn about README file, Wirefram and Github
</p>
</header>

<main>
<article>
<img src="https://media.geeksforgeeks.org/wp-content/uploads/20210915020701/Readme1.png" alt="Readme1.png" />
<h2>README file </h2>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
A README file is a comprehensive guide that helps users, contributors, and developers interact with the project effectively.
And It provides a summary of the project, including its purpose, key features, and goals. This helps users and contributors understand what the project is about at a glance.
</p>
<a href="">Read more</a>
<a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a>
</article>
</main>
<footer>
<p>
This is the default, provided code and no changes have been made yet.
</p>
</footer>
</body>
</html>

<section class="mini-atricles">
<article>
<img src="https://cdn-proxy.slickplan.com/wp-content/uploads/2019/08/What-is-Wireframing.jpg" alt="What-is-Wireframing.jpg" width="100%"/>

<h3> Wireframe </h3>
<p>wireframes are an essential step in the design process, providing a clear and organized way to plan and communicate the layout and functionality of a digital product.
It provides a clear outline of where different elements (such as menus, buttons, content areas, and images) will be placed on a page. This helps ensure that the layout is logical and user-friendly.
</p>
<a href="https://www.experienceux.co.uk/faqs/what-is-wireframing/#:~:text=A%20wireframe%20is%20commonly%20used,design%20and%20content%20is%20added.">Read more</a>

</article>
</section>

<section>
<article>
<img src="https://th.bing.com/th/id/OIP.USzUm_JCL74opilCqyks_QHaFM?rs=1&pid=ImgDetMain" alt="Wireframe/image.png/OIP.jfif" width="100%"/>

<h3> Git Branch </h3>
<p>
In Git, a branch is a parallel version of your repository that diverges from the main working project. It allows you to work on different tasks, features, or fixes separately from the main codebase.
Using branches effectively helps keep your project organized and ensures that the main codebase remains stable.
</p>
<a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read more</a>

</article>
</section>

</main>
<footer>
<p>Creat by Yorsalem Mesmer</p>
</footer>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

footer's position fixed okay but user does not really understand what that part is really about, it would be nice to show your footer area with e.i background color

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a background colour to the footer.


<body>

Empty file added Wireframe/jpg
View file
Open in desktop
Empty file.
27 changes: 14 additions & 13 deletions Wireframe/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ As well as useful links to learn more */
/* ====== Base Elements ======
General rules for basic HTML elements in any context */
body {
background: var(--paper);
color: var(--ink);
font: var(--font);
background: rgb(207, 193, 232);
color: rgb(14, 14, 25);
float: inline-start;
}
a {
padding: var(--space);
border: var(--line);
padding: 100% 1.5;
border: 1px solid;
max-width: fit-content;
}
img,
Expand All @@ -46,10 +46,11 @@ Setting the overall rules for page regions
https://www.w3.org/WAI/tutorials/page-structure/regions/
*/
main {
max-width: var(--container);
margin: 0 auto calc(var(--space) * 4) auto;
max-width: 1300px;
margin: auto;
}
footer {
background-color: rgb(156, 151, 152);
position: fixed;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as best practice footers are generally stretched to its container, this is a design enhancement, you don't have to do it, but it is better to practice more which will improve your UI and UX skills

bottom: 0;
text-align: center;
Expand All @@ -64,7 +65,7 @@ https://gridbyexample.com/learn/
main {
display: grid;
grid-template-columns: 1fr 1fr;
gap: var(--space);
gap: 15px;
> *:first-child {
grid-column: span 2;
}
Expand All @@ -75,13 +76,13 @@ Now laying out just the INSIDE of the repeated card/article design.
Keeping things orderly and separate is the key to good, simple CSS.
*/
article {
border: var(--line);
padding-bottom: var(--space);
text-align: left;
display: grid;
border: 1px solid;
padding-bottom: 10px;
text-align: center;
display: flexbox;
grid-template-columns: var(--space) 1fr var(--space);
> * {
grid-column: 2/3;
grid-column: span 2/3 ;
}
> img {
grid-column: span 3;
Expand Down
15 changes: 15 additions & 0 deletions Wireframe/yorsalem-mesmer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
ITP_JAN_25 / YORSALEM MESMER / Model-Onbording / Week 1

# Your Details

- Your Name: YORSALEM MESMER
- Your City: LONDON
- Your Slack Name: yorsalem

# Homework Details

- Module: Wireframe
- Week: 1