Millena mesfin/Sprint-2-exercices /structuring and testing data #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Millena28
commented
Dec 9, 2024
cjyuan
reviewed
Dec 11, 2024
| // Line#5; we need to make getLastDigit accept a parameter. | ||
|
|
||
| function getLastDigit(number) { | ||
| return num.toString().slice(-1); |
There was a problem hiding this comment.
Have you executed your script to verify your function can correctly return the last digit?
I don't think console.log( getLastDigit(806) ) will output 6 with your current implementation.
| // .replace(/ /g, "_") uses a regular expression to replace all spaces in the string with underscores (_), where the /g flag ensures that all spaces are replaced (not just the first one). | ||
| // Using .replace(/ /g, "_") with the g flag tells JavaScript to replace all spaces in the string, not just the first one. | ||
| // /g: Replaces all occurrences of the pattern, but is case-sensitive. | ||
| // /gi: Replaces all occurrences of the pattern and is case-insensitive. |
There was a problem hiding this comment.
You are using / /gi (instead of / /g) in your code. How does the i flag affect the result?
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.