-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYF-ITP-South Africa | Rashaad Ebrahim | Module-Structuring-and-Testing-Data | Week 3 #225
base: main
Are you sure you want to change the base?
CYF-ITP-South Africa | Rashaad Ebrahim | Module-Structuring-and-Testing-Data | Week 3 #225
Conversation
Test file completed
isProperFraction function updated.
Each I am not sure why you need short/long test in your 'is-prime.test.js`. If a short test fails, what's the reason to run the longer version? Here is one possible way to perform test B if test A fails:
|
@shreefAhmedM I noticed that you have added the "Reviewed" label in this PR, but I cannot see any of your comment. Have you reviewed Rashaad code and gave feedback to Rashaad accordingly? |
Thanks @cjyuan, I'll give that a try. I know this isn't a great scenario to run a "short" and "long" test, the idea just came to me and I wanted to know if its possible in the event I ever want to use it in another application. |
@Rashaad-Ebrahim Does this PR still need any review? |
|
@cjyuan I do still ned my PR reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is well written and tests are very comprehensive!
I left some comments and suggestions.
The function in get-card-value.js
can miss some invalid cases.
Suggested changes have been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Just few more suggestions.
Changes implemented. |
You can mark your PR as "completed" any time you think you have made all the changes. You don't have to request for review for every change. |
Learners, PR Template
Self checklist
Changelist
Exercises completed and all necessary tests created.
Questions
On the
is-prime.test.js
, I created fours tests. Two related to testing prime numbers, and two related to testing non- prime numbers.Of the two tests, the first test is to check if the function was working correctly. What I was trying to, was run the first test and if it failed, then only would the second test be run. The second test would then indicate where the error is coming from.
Is this even possible with Jest? I tried many different thing but to no avail. Any input?
What I wanted to to