LONDON001/LOVETH-CLARA-OKAFOR/Module-Structuring-and-Testing-Data/WEEK2-/SPRINT-2 #228
Conversation
loveth900
added
📅 Sprint 2
|
Hi @cjyuan its will be a pleasure if you can help review my work, and i must say that am glad working with you cause the errors makes me know a lot of things, kind regard. |
|
"Completed" or "Need Review"? |
loveth900
added
Needs Review
|
hi @cjyuan its need review, its an error sorry for that, |
| @@ -1,8 +1,19 @@ | |||
| // Predict and explain first... | |||
| // Prediction : it will return "the sum of 10 and 32 is null". Because the function returns something but it's null. | |||
There was a problem hiding this comment.
undefined is not the same as null in JS. So which value is returned from the original function?
| @@ -1,4 +1,5 @@ | |||
| // Predict and explain first... | |||
| // Prediction : I think the function won't return anything because it's using console.log() and not return. | |||
There was a problem hiding this comment.
Todo
The instructions in readme.md also ask for "correcting the code".
| a + b; | ||
| } | ||
|
|
||
| console.log(`The sum of 10 and 32 is ${sum(10, 32)}`); |
There was a problem hiding this comment.
Todo
The current script still does not show the sum as 42. You also need to correct the code in the function.
| function capitalise(str) { | ||
| let str = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| str = `${str[0].toUpperCase()}${str.slice(1)}`; // No `let`, just reassign |
There was a problem hiding this comment.
Alternatively, you can declare a new variable or just return the value of the expression (without storing the value in a variable first).
| { input: "00:01", expected: "12:01 am" }, | ||
| { input: "12:01", expected: "12:01 pm" }, | ||
| { input: "13:00", expected: "1:00 pm" }, | ||
| ]; |
There was a problem hiding this comment.
Todo
You also need fix the function if any test fails.
| @@ -4,3 +4,13 @@ | |||
| // You will need to declare a function called toPounds with an appropriately named parameter. | |||
|
|
|||
| // You should call this function a number of times to check it works for different inputs | |||
|
|
|||
|
|
|||
| function toPounds(kilograms) { | |||
There was a problem hiding this comment.
Todo
If you refer to interpret/to-pounds.js in Sprint 1, you will find the code there is to convert pence string in the form "399p" to British pound "£3.99". This function should be based on those code.
| @@ -29,3 +29,6 @@ function formatTimeDisplay(seconds) { | |||
| // d) What is the value assigned to num when pad is called for the last time in this program? Explain your answer | |||
|
|
|||
| // e) What is the return value assigned to num when pad is called for the last time in this program? Explain your answer | |||
|
|
|||
There was a problem hiding this comment.
Todo
In this exercise, you need to answer questions (a)-(e) by tracing the execution of the code (that is, figure out in what order every statement and every function call is executed) .
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.