West Midlands | Alireza Seifi Shalamzari | Module-Structuring-and-Testing-Data | Week 3 #231
Conversation
There was a problem hiding this comment.
The code in the 4 .js files you implemented are quite solid.
You also prepared many good test cases but you were not using console.assert() or Jest to specify the tests.
There are a few more exercises in folder revised not yet included in this branch.
Do you need help setting up Jest or using it to specify unit tests? You can seek help from a volunteer in a workshop on Saturday or DM me on Slack to make an appointment. You can also do the same if you need some guidance in these exercises.
Sprint-3/implement/get-angle-type.js
Outdated
| console.log(getAngleType(0)); // Should print "Invalid angle" | ||
| console.log(getAngleType(-45)); // Should print "Invalid angle" |
There was a problem hiding this comment.
Does these two show "Invalid angle"?
It is not easy to spot the error from just console.log() output. That's one reason why a test framework like Jest can help us identify cases when a return value does not match an expected value.
There was a problem hiding this comment.
I changed the testing method to Jest
| const rank = card.slice(0, -1); | ||
|
|
||
| // Handle Number Cards (2-9) | ||
| if (rank >= "2" && rank <= "9") { |
There was a problem hiding this comment.
Todo
This check is not solid enough.
You can test your function by calling getCardValue("23♠") or getCardValue("899♠") to see what they return.
There was a problem hiding this comment.
I did work on this and I found a solution!
I added a set of valid ranks so only the valid ones can return an actual value
| //Testing the function | ||
| console.log(isProperFraction(2, 3)); //should return True | ||
| console.log(isProperFraction(5, 2)); //should return False | ||
| console.log(isProperFraction(-4, 7)); //should return True |
There was a problem hiding this comment.
In mathematics, -4/7 == 4/-7, and -4/-7 == 4/7.
So, ideally isProperFraction() should recognise all of them as proper fractions.
Hint: If you compute the absolute value of both parameters inside the function first, the code can become much simpler.
There was a problem hiding this comment.
I added a part which first make absolute numbers then check them
cjyuan
added
👀 Review Requirements
Self checklist
Changelist
This pull request is created to show the completion of Sprint 3
Questions
Notes
For the file Rotate Char, it was too hard to do!