Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYF London | Rihanna Poursoltani | Module Structuring and Testing Data | Sprint 3 #239

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

CYF London | Rihanna Poursoltani | Module Structuring and Testing Data | Sprint 3 #239

wants to merge 11 commits into from

Conversation

RihannaP
Copy link

@RihannaP RihannaP commented Jan 8, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@RihannaP RihannaP added the Needs Review Participant to add when requesting review label Jan 8, 2025
vamsikrishna-oc
vamsikrishna-oc reviewed Jan 8, 2025
View reviewed changes
Sprint-3/implement/get-angle-type.test.js Show resolved Hide resolved
Sprint-3/implement/is-valid-triangle.js Outdated Show resolved Hide resolved
Sprint-3/implement/rotate-char.test.js Show resolved Hide resolved
Sprint-3/revise/implement/card-validator.js Outdated Show resolved Hide resolved
Sprint-3/revise/implement/is-prime.test.js Show resolved Hide resolved
Sprint-3/revise/implement/is-prime.test.js Outdated Show resolved Hide resolved
Sprint-3/revise/implement/password-validator.test.js Outdated Show resolved Hide resolved
@vamsikrishna-oc vamsikrishna-oc added the Reviewed Volunteer to add when completing a review label Jan 8, 2025
@RihannaP RihannaP added Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamsikrishna-oc vamsikrishna-oc vamsikrishna-oc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RihannaP @vamsikrishna-oc