Skip to content

Commit

Permalink
put the div back
Browse files Browse the repository at this point in the history
sorry thought i had pushed this
  • Loading branch information
SallyMcGrath committed Dec 6, 2024
1 parent 9def2ea commit b55203f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 12 deletions.
4 changes: 2 additions & 2 deletions org-cyf-itp/assets/custom-scripts/reviews/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ async function onLoad() {
const bucket = overviewCard.querySelector(
`.age-bucket.${age.replaceAll(" ", "-")} .count`
);
if (bucket) bucket.innerText = count;
if (bucket && badness(age, count) === 900) {
bucket.innerText = count;
if (badness(age, count) === 900) {
bucket.classList.add("problem");
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@
&__card {
box-shadow: var(--theme-box-shadow--slim);
padding: var(--theme-spacing--1);
display: grid;
gap: var(--theme-spacing--1);
}
}
21 changes: 11 additions & 10 deletions org-cyf-itp/layouts/_default/needs-review.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,17 @@ <h3 class="c-pr-overview__module e-heading__5 module"></h3>
<p class="c-pr-overview__description e-heading__6 ">
PRs needing review from:
</p>
<dl class="c-pr-overview__age age-container">
<dt class="c-pr-overview__bucket age-bucket this-week">This week</dt>
<dd class="c-pr-overview__count count"></dd>
<dt class="c-pr-overview__bucket age-bucket this-month">
2-4 weeks ago
</dt>
<dd class="c-pr-overview__count count"></dd>
<dt class="c-pr-overview__count age-bucket old">4+ weeks ago</dt>
<dd class="c-pr-overview__count count"></dd>
</dl>
<div class="c-pr-overview__age age-container">
<div class="age-bucket this-week">
This week: <strong class="count"></strong>
</div>
<div class="age-bucket this-month">
2-4 weeks ago: <strong class="count"></strong>
</div>
<div class="age-bucket old">
4+ weeks ago: <strong class="count"></strong>
</div>
</div>
<div class="c-pr-overview__values summary-values"></div>
</div>
</section>
Expand Down

0 comments on commit b55203f

Please sign in to comment.