Rework 24 hour clock worked example prep #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-curriculum canceled.
|
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-common canceled.
|
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-itd canceled.
|
illicitonion
force-pushed
the
rework-std-sprint2
branch
from
50789f7 to
201c2a5
Compare
SallyMcGrath
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Loving it so far.
I'm going to stop reviewing because there are two general themes which you can just run with.
- Break up your sentences.
- Convert 2/3 of your information into activities, retaining the first piece as a worked example and the last piece/ your summary analysis.
Then let's go again! 🚀 ❤️ 🙌
common-content/en/module/js1/identifying-missing-tests/index.md
Outdated
Show resolved
Hide resolved
common-content/en/module/js1/identifying-missing-tests/index.md
Outdated
Show resolved
Hide resolved
* Pull out an entire prep block about interpreting errors - we frequently see trainees ignore errors and wildly guess, this tries to guide away from that more. * Also a block about strategies to handle errors when we run into them. * Split "how to conditionals" and "what to do in the other branch" into two separate stages of solving the problem, and add "test and get feedback you've solved one of them" as a suggested step before solving the other one. * Explain why we need to convert to numbers before comparing strings. * Add a block on refactoring out repetition * Add a block about identifying classes of input and edge cases. I've added a prep exercise to continue the edge-case finding.
illicitonion
force-pushed
the
rework-std-sprint2
branch
from
201c2a5 to
b63e7cc
Compare
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
SallyMcGrath
approved these changes
Oct 23, 2024
common-content/en/module/js1/identifying-missing-tests/index.md
Outdated
Show resolved
Hide resolved
common-content/en/module/js1/identifying-missing-tests/index.md
Outdated
Show resolved
Hide resolved
common-content/en/module/js1/identifying-missing-tests/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
Co-authored-by: Sally McGrath <[email protected]>
This was referenced Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I've added a prep exercise to continue the edge-case finding in CodeYourFuture/Module-Structuring-and-Testing-Data#41.
Fixes #243
Common Content?
Yes, it reworks a lot of js1 blocks.
Hopefully anyone depending on these blocks will be broken by the fact that the
js1/assemblyblock has been removed, and will see they need to update what they pull in.Org Content?
Sprint
Checklist