Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step 0 #1101

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Add step 0 #1101

merged 7 commits into from
Oct 24, 2024

Conversation

Ara225
Copy link
Contributor

@Ara225 Ara225 commented Oct 20, 2024

What does this change?

This adds ITD step zero which previously only existed in the dashboard. In addition, it makes some edits to step zero to conform with the requirements of #1057

Common Content?

No

Common Theme?

No

Issue number: #1057 #958

Org Content?

No

Checklist

Who needs to know about this?

@kfklein15

@Ara225 Ara225 requested a review from kfklein15 October 20, 2024 09:31
Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6719fecf2e181200080a8e84

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6719fecfea50d40008e20d6e
😎 Deploy Preview https://deploy-preview-1101--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6719fecfb7da1b0008ec9e87

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6719fecf744d1b00086b7336
😎 Deploy Preview https://deploy-preview-1101--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6719fecfa4e7dc0008cfc611
😎 Deploy Preview https://deploy-preview-1101--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6719fecff823fb000804b3fa
😎 Deploy Preview https://deploy-preview-1101--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6719fecf8a37520008c612ec
😎 Deploy Preview https://deploy-preview-1101--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify language, fix paths

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 2918e5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6719fecf48969900081cde20
😎 Deploy Preview https://deploy-preview-1101--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ara225 I've updated the paths directly because it's faster than explaining. I've left the weight update for you to do - and put the deploy through so you can see the effect.

org-cyf-itd/content/steps/zero/index.md Outdated Show resolved Hide resolved
@Ara225
Copy link
Contributor Author

Ara225 commented Oct 20, 2024

Thank you 😊

@Ara225
Copy link
Contributor Author

Ara225 commented Oct 22, 2024

Done, makes sense

@SallyMcGrath SallyMcGrath self-requested a review October 24, 2024 09:56
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SallyMcGrath SallyMcGrath merged commit 772a37d into CodeYourFuture:main Oct 24, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants