Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring tooltips further forward #1110

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Bring tooltips further forward #1110

merged 2 commits into from
Oct 24, 2024

Conversation

illicitonion
Copy link
Member

@illicitonion illicitonion commented Oct 22, 2024

Tab titles are already at 2.

I'm sorry Sally.

Fixes #1106

Tab titles are already at 2.

I'm sorry Sally.
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/671a327dd8632900087c1bd4
😎 Deploy Preview https://deploy-preview-1110--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/671a327de2927900088bc046

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/671a327d39f34200084f1f3a

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/671a327df695e800082cfae9
😎 Deploy Preview https://deploy-preview-1110--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/671a327d0587ce0008b12d1c

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/671a327d0560520009a65bf1
😎 Deploy Preview https://deploy-preview-1110--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/671a327d0bae970007fdd840
😎 Deploy Preview https://deploy-preview-1110--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit fa3e8e1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/671a327dbec5b5000825e08b
😎 Deploy Preview https://deploy-preview-1110--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath
Copy link
Member

It's just not the ultimate answer! It will keep happening! There's a better solution. 😛

@SallyMcGrath SallyMcGrath added this to the Common Theme Release milestone Oct 24, 2024
@SallyMcGrath SallyMcGrath self-assigned this Oct 24, 2024
@illicitonion illicitonion merged commit a832a51 into main Oct 24, 2024
34 checks passed
@illicitonion illicitonion deleted the tooltips-to-the-front branch October 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Tooltips and tabs still need more z-index hacking
2 participants