Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

857 Data Groups / Sprint 1 - Referenced Medium article is member-only #1116

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Oct 23, 2024

Fixes #857

live debug on this PR to store context for if/when this happens again.

So it's updated on the repo but not on our mount of the repo. (CYF-PD is a hugo module)

Therefore I posit that the modules are being cached somewhere. ...

Clearing caches on netlify does nothing

Running on local -- same old cached link as on netlify. Is therefore this mount pegged to a specific version of CYF-PD?

I look in org-cyf-itp/go.mod - it has a version but it's not clear that this is pinned.

I run hugo mod get -u to see if the versions changes

It does change

I run local again and check the link -- it's updated

So I will fix this by running an update and committing that updated go.mod for now, but maybe there's some better approach because this fails the "consistency check". @illicitonion can you advise?

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit a56e37b
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/671a4866267ddc000885699c
😎 Deploy Preview https://deploy-preview-1116--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 23, 2024
@SallyMcGrath SallyMcGrath added the blocked Blocked by something explained in comments label Oct 23, 2024
@illicitonion
Copy link
Member

So I will fix this by running an update and committing that updated go.mod for now, but maybe there's some better approach because this fails the "consistency check". @illicitonion can you advise?

The failing CI job gave a suggestion of what to do; specifically:

⚠️  File at path /home/runner/work/curriculum/curriculum/org-cyf-itp/go.mod didn't have some local overrides - its contents should be:
module github.com/CodeYourFuture/curriculum/org-cyf-itp

go 1.22.6

require (
	github.com/CodeYourFuture/CYF-PD v1.0.1-0.2024090[5](https://github.com/CodeYourFuture/curriculum/actions/runs/11495787283/job/31996069422?pr=1116#step:5:6)150045-7be086ff6886 // indirect
	github.com/CodeYourFuture/curriculum/common-content v0.0.0-20241022142[7](https://github.com/CodeYourFuture/curriculum/actions/runs/11495787283/job/31996069422?pr=1116#step:5:8)07-ee3974f1[8](https://github.com/CodeYourFuture/curriculum/actions/runs/11495787283/job/31996069422?pr=1116#step:5:9)eb2 // indirect
	github.com/CodeYourFuture/curriculum/common-theme v0.0.0-20241022142707-ee3[9](https://github.com/CodeYourFuture/curriculum/actions/runs/11495787283/job/31996069422?pr=1116#step:5:10)74f18eb2 // indirect
	github.com/CodeYourFuture/curriculum/org-cyf-guides v0.0.0-2024[10](https://github.com/CodeYourFuture/curriculum/actions/runs/11495787283/job/31996069422?pr=1116#step:5:11)22142707-ee3974f18eb2 // indirect
	github.com/CodeYourFuture/curriculum/org-cyf-how-this-works v0.0.0-20241022142707-ee3974f18eb2 // indirect
	github.com/CodeYourFuture/curriculum/org-cyf-piscine v0.0.0-20241022142707-ee3974f18eb2 // indirect
	github.com/CodeYourFuture/curriculum/org-cyf-theme v0.0.0-20241022142707-ee3974f18eb2 // indirect
)

replace github.com/CodeYourFuture/curriculum/common-content => ../common-content

replace github.com/CodeYourFuture/curriculum/common-theme => ../common-theme

replace github.com/CodeYourFuture/curriculum/org-cyf-guides => ../org-cyf-guides

replace github.com/CodeYourFuture/curriculum/org-cyf-how-this-works => ../org-cyf-how-this-works

replace github.com/CodeYourFuture/curriculum/org-cyf-piscine => ../org-cyf-piscine

replace github.com/CodeYourFuture/curriculum/org-cyf-theme => ../org-cyf-theme

If you replace org-cyf-itp/go.mod with the above, things should work.

It looks like your hugo mod get -u added a dependency on github.com/CodeYourFuture/curriculum/org-cyf-theme which wasn't there before, so we need to add an override for it.

How could the tooling have reported this better to make it more clear?

@illicitonion
Copy link
Member

Also, do we want CI (maybe in a nightly job?) to automatically run hugo mod get -u and either fail a build if there were changes, or create a PR with the changes or something? Otherwise I don't think we're going to pick up new edits to out-of-tree modules like CYF-PD?

@SallyMcGrath
Copy link
Member Author

SallyMcGrath commented Oct 24, 2024

So I will fix this by running an update and committing that updated go.mod for now, but maybe there's some better approach because this fails the "consistency check". @illicitonion can you advise?

The failing CI job gave a suggestion of what to do; specifically:

⚠️  File at path /home/runner/work/curriculum/curriculum/org-cyf-itp/go.mod didn't have some local overrides - its contents should be:
module github.com/CodeYourFuture/curriculum/org-cyf-itp

go 1.22.6

require (
	github.com/CodeYourFuture/CYF-PD v1.0.1-0.2024090[5](https://github.com/CodeYourFuture/curriculum/actions/runs/11495787283/job/31996069422?pr=1116#step:5:6)150045-7be086ff6886 // indirect
	[..]

If you replace org-cyf-itp/go.mod with the above, things should work.

It looks like your hugo mod get -u added a dependency on github.com/CodeYourFuture/curriculum/org-cyf-theme which wasn't there before, so we need to add an override for it.

How could the tooling have reported this better to make it more clear?

Oh, when I read this I thought it was telling me that I couldn't update the version in this go.mod and pass this check. That I would have to revert my changes to stay consistent, to this required set. What is it telling me? It's just telling me about the theme? Could it call out this explicitly at the top?

@illicitonion
Copy link
Member

I just pushed an update to the wording of the tooling - how does the output of https://github.com/CodeYourFuture/curriculum/actions/runs/11499627400/job/32008009387?pr=1116 look?

@SallyMcGrath
Copy link
Member Author

I just pushed an update to the wording of the tooling - how does the output of https://github.com/CodeYourFuture/curriculum/actions/runs/11499627400/job/32008009387?pr=1116 look?

really great - ty!

Copy link
Member Author

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to approve this @illicitonion

@SallyMcGrath SallyMcGrath merged commit 141df07 into main Oct 24, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the bug/857-cached-link branch October 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by something explained in comments
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Data Groups / Sprint 1 - Referenced Medium article is member-only
2 participants