-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
857 Data Groups / Sprint 1 - Referenced Medium article is member-only #1116
Conversation
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The failing CI job gave a suggestion of what to do; specifically:
If you replace It looks like your How could the tooling have reported this better to make it more clear? |
Also, do we want CI (maybe in a nightly job?) to automatically run |
Oh, when I read this I thought it was telling me that I couldn't update the version in this go.mod and pass this check. That I would have to revert my changes to stay consistent, to this required set. What is it telling me? It's just telling me about the theme? Could it call out this explicitly at the top? |
I just pushed an update to the wording of the tooling - how does the output of https://github.com/CodeYourFuture/curriculum/actions/runs/11499627400/job/32008009387?pr=1116 look? |
really great - ty! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to approve this @illicitonion
Fixes #857
live debug on this PR to store context for if/when this happens again.
So it's updated on the repo but not on our mount of the repo. (CYF-PD is a hugo module)
Therefore I posit that the modules are being cached somewhere. ...
Clearing caches on netlify does nothing
Running on local -- same old cached link as on netlify. Is therefore this mount pegged to a specific version of CYF-PD?
I look in org-cyf-itp/go.mod - it has a version but it's not clear that this is pinned.
I run
hugo mod get -u
to see if the versions changesIt does change
I run local again and check the link -- it's updated
So I will fix this by running an update and committing that updated go.mod for now, but maybe there's some better approach because this fails the "consistency check". @illicitonion can you advise?