Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1105 Include more theme/heading information on index pages #1130

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

SallyMcGrath
Copy link
Member

PR 1 of 3

Fixes #1105 (comment)

brings theme onto module index view

obviously I hate this but I will endure it
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 31e3c04
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/671a65c5205a4b0008bde341
😎 Deploy Preview https://deploy-preview-1130--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 31e3c04
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/671a65c5ee3ee800085a4b47
😎 Deploy Preview https://deploy-preview-1130--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 31e3c04
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/671a65c547ecf100086b9d26
😎 Deploy Preview https://deploy-preview-1130--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 31e3c04
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/671a65c5584c560008a19980
😎 Deploy Preview https://deploy-preview-1130--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 31e3c04
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/671a65c5ba8d8e000814add7
😎 Deploy Preview https://deploy-preview-1130--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 31e3c04
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/671a65c51ced0d0008f3087a

@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 24, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 24, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great (with small suggested edits in #1134) - thanks!

illicitonion and others added 2 commits October 24, 2024 16:20
If we're displaying these more prominently, these seem more useful :)
@SallyMcGrath SallyMcGrath merged commit a9f6fcc into main Oct 24, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/1105-1-theme-on-index branch October 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include more theme/heading information on index pages
2 participants